[mypyc] Document some of our inheritance conventions #19370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our policy wasn't clear from just reading the code.
Comment on lines
+22
to
+23
| This makes it possible to use isinstance(x, <concrete Value | ||
| subclass>) checks without worrying about potential subclasses. |
Member
There was a problem hiding this comment.
Would it be a good idea to mark the concrete classes as @final to document/enforce this?
On a somewhat related noted, can/does mypyc optimize isinstance checks with final types?
Collaborator
Author
There was a problem hiding this comment.
I like that, added @final to the concrete classes. By default @final doesn't help with optimizations, since mypyc can perform whole-program analysis. However, @final would help with isinstance checks if doing separate compilation (but this is currently poorly supported).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our policy wasn't clear from just reading the code.